Fix disable autoinstall for a single module when AUTOINSTALL='no' is set #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hongyuntw please rebase the branch, we have test fixes already in main. |
hongyuntw
force-pushed
the
fix-autoinstall-single-module
branch
from
2ce965d to
2a5129b
Compare
|
@scaronni done! |
|
I have a slightly more generic solution queued ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we want to specifically disable the autoinstall functionality for a certain module, we can either remove the AUTOINSTALL-related settings from the module's dkms.conf file or set
AUTOINSTALL="no". However, the currentautoinstallfunction does not handle this properly. In other words, even if a module hasAUTOINSTALL="no", it will still be automatically installed, which is not the expected behavior.