Skip to content

Commit 833898c

Browse files
felixs88felixs88
authored
Release 5.3.0 (#402)
* Release 5.3.0 * Release 5.3.0 * Release 5.3.0 * Release 5.3.0 * Release 5.3.0 * Release 5.3.0 * Release 5.3.0 * Release 5.3.0 * Release 5.3.0 * Release 5.3.0 * Release 5.3.0
1 parent 439e9f3 commit 833898c

20 files changed

+682
-188
lines changed

‎.github/workflows/ansible-test.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,9 @@ jobs:
8686
run: ansible-test units -v --color --python ${{ matrix.python-version }} --coverage
8787
working-directory: /home/runner/.ansible/collections/ansible_collections/dellemc/openmanage
8888

89-
- name: Generate coverage report
90-
run: ansible-test coverage xml -v --group-by command --group-by version
91-
working-directory: /home/runner/.ansible/collections/ansible_collections/dellemc/openmanage
89+
#- name: Generate coverage report
90+
# run: ansible-test coverage xml -v --group-by command --group-by version
91+
# working-directory: /home/runner/.ansible/collections/ansible_collections/dellemc/openmanage
9292

9393
###
9494
# Sanity tests (REQUIRED)

‎CHANGELOG.rst

+30
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,36 @@ Dell EMC OpenManage Ansible Modules Release Notes
55
.. contents:: Topics
66

77

8+
v5.3.0
9+
======
10+
11+
Release Summary
12+
---------------
13+
14+
Added check mode and idempotency support for redfish_storage_volume and idempotency support for ome_smart_fabric_uplink. For ome_diagnostics, added support for debug logs and added supportassist_collection as a choice for the log_type argument to export SupportAssist logs.
15+
16+
Minor Changes
17+
-------------
18+
19+
- ome_diagnostics - Added "supportassist_collection" as a choice for the log_type argument to export SupportAssist logs. (https://github.com/dell/dellemc-openmanage-ansible-modules/issues/309)
20+
- ome_diagnostics - The module is enhanced to support debug logs. (https://github.com/dell/dellemc-openmanage-ansible-modules/issues/308)
21+
- ome_smart_fabric_uplink - The module is enhanced to support idempotency. (https://github.com/dell/dellemc-openmanage-ansible-modules/issues/253)
22+
- redfish_storage_volume - The module is enhanced to support check mode and idempotency. (https://github.com/dell/dellemc-openmanage-ansible-modules/issues/245)
23+
24+
Known Issues
25+
------------
26+
27+
- idrac_user - Issue(192043) The module may error out with the message ``unable to perform the import or export operation because there are pending attribute changes or a configuration job is in progress``. Wait for the job to complete and run the task again.
28+
- ome_application_alerts_smtp - Issue(212310) - The module does not provide a proper error message if the destination_address is more than 255 characters.
29+
- ome_application_alerts_syslog - Issue(215374) - The module does not provide a proper error message if the destination_address is more than 255 characters.
30+
- ome_application_console_preferences - Issue(224690) - The module does not display a proper error message when an unsupported value is provided for the parameters report_row_limit, email_sender_settings, and metric_collection_settings, and the value is applied on OpenManage Enterprise.
31+
- ome_device_local_access_configuration - Issue(215035) - The module reports ``Successfully updated the local access setting`` if an unsupported value is provided for the parameter timeout_limit. However, this value is not actually applied on OpenManage Enterprise Modular.
32+
- ome_device_local_access_configuration - Issue(217865) - The module does not display a proper error message if an unsupported value is provided for the user_defined and lcd_language parameters.
33+
- ome_device_network_services - Issue(212681) - The module does not provide a proper error message if unsupported values are provided for the parameters- port_number, community_name, max_sessions, max_auth_retries, and idle_timeout.
34+
- ome_device_power_settings - Issue(212679) - The module displays the following message if the value provided for the parameter ``power_cap`` is not within the supported range of 0 to 32767, ``Unable to complete the request because PowerCap does not exist or is not applicable for the resource URI.``
35+
- ome_device_quick_deploy - Issue(216352) - The module does not display a proper error message if an unsupported value is provided for the ipv6_prefix_length and vlan_id parameters.
36+
- ome_smart_fabric_uplink - Issue(186024) - The module does not allow the creation of multiple uplinks of the same name even though it is supported by OpenManage Enterprise Modular. If an uplink is created using the same name as an existing uplink, the existing uplink is modified.
37+
838
v5.2.0
939
======
1040

‎changelogs/changelog.yaml

+52-1
Original file line numberDiff line numberDiff line change
@@ -692,4 +692,55 @@ releases:
692692
- description: Configures console preferences on OpenManage Enterprise.
693693
name: ome_application_console_preferences
694694
namespace: ''
695-
release_date: '2022-03-29'
695+
release_date: '2022-03-29'
696+
5.3.0:
697+
changes:
698+
minor_changes:
699+
- redfish_storage_volume - The module is enhanced to support check mode and idempotency.
700+
(https://github.com/dell/dellemc-openmanage-ansible-modules/issues/245)
701+
- ome_smart_fabric_uplink - The module is enhanced to support idempotency.
702+
(https://github.com/dell/dellemc-openmanage-ansible-modules/issues/253)
703+
- ome_diagnostics - The module is enhanced to support debug logs.
704+
(https://github.com/dell/dellemc-openmanage-ansible-modules/issues/308)
705+
- ome_diagnostics - Added "supportassist_collection" as a choice for the log_type argument
706+
to export SupportAssist logs.
707+
(https://github.com/dell/dellemc-openmanage-ansible-modules/issues/309)
708+
known_issues:
709+
- ome_application_console_preferences - Issue(224690) - The module does
710+
not display a proper error message when an unsupported value is provided
711+
for the parameters report_row_limit, email_sender_settings, and
712+
metric_collection_settings, and the value is applied on OpenManage Enterprise.
713+
- ome_device_quick_deploy - Issue(216352) - The module does not display a
714+
proper error message if an unsupported value is provided for the
715+
ipv6_prefix_length and vlan_id parameters.
716+
- ome_device_local_access_configuration - Issue(217865) - The module does not
717+
display a proper error message if an unsupported value is provided for the
718+
user_defined and lcd_language parameters.
719+
- ome_device_local_access_configuration - Issue(215035) - The module reports
720+
``Successfully updated the local access setting`` if an unsupported value is
721+
provided for the parameter timeout_limit. However, this value is not
722+
actually applied on OpenManage Enterprise Modular.
723+
- ome_device_network_services - Issue(212681) - The module does not provide a
724+
proper error message if unsupported values are provided for the parameters-
725+
port_number, community_name, max_sessions, max_auth_retries, and idle_timeout.
726+
- ome_application_alerts_syslog - Issue(215374) - The module does not provide a
727+
proper error message if the destination_address is more than 255 characters.
728+
- ome_application_alerts_smtp - Issue(212310) - The module does not provide a
729+
proper error message if the destination_address is more than 255 characters.
730+
- idrac_user - Issue(192043) The module may error out with the message ``unable
731+
to perform the import or export operation because there are pending attribute
732+
changes or a configuration job is in progress``. Wait for the job to complete
733+
and run the task again.
734+
- ome_smart_fabric_uplink - Issue(186024) - The module does not allow the creation
735+
of multiple uplinks of the same name even though it is supported by OpenManage
736+
Enterprise Modular. If an uplink is created using the same name as an existing
737+
uplink, the existing uplink is modified.
738+
- ome_device_power_settings - Issue(212679) - The module displays the following
739+
message if the value provided for the parameter ``power_cap`` is not within
740+
the supported range of 0 to 32767, ``Unable to complete the request
741+
because PowerCap does not exist or is not applicable for the resource URI.``
742+
release_summary: Added check mode and idempotency support for redfish_storage_volume
743+
and idempotency support for ome_smart_fabric_uplink. For ome_diagnostics, added
744+
support for debug logs and added supportassist_collection as a choice for the log_type
745+
argument to export SupportAssist logs.
746+
release_date: '2022-04-26'

‎docs/modules/ome_diagnostics.rst

+12-10
Original file line numberDiff line numberDiff line change
@@ -30,23 +30,23 @@ Parameters
3030
device_ids (optional, list, None)
3131
List of target device IDs.
3232

33-
This is applicable for ``support_assist_collection`` logs.
33+
This is applicable for ``support_assist_collection`` and ``supportassist_collection`` logs.
3434

3535
This option is mutually exclusive with *device_service_tags* and *device_group_name*.
3636

3737

3838
device_service_tags (optional, list, None)
3939
List of target identifier.
4040

41-
This is applicable for ``support_assist_collection`` logs.
41+
This is applicable for ``support_assist_collection`` and ``supportassist_collection`` logs.
4242

4343
This option is mutually exclusive with *device_ids* and *device_group_name*.
4444

4545

4646
device_group_name (optional, str, None)
47-
Name of the device group to export ``support_assist_collection`` logs of all devices within the group.
47+
Name of the device group to export ``support_assist_collection`` or ``supportassist_collection`` logs of all devices within the group.
4848

49-
This is applicable for ``support_assist_collection`` logs.
49+
This is applicable for ``support_assist_collection`` and ``supportassist_collection`` logs.
5050

5151
This option is not applicable for OpenManage Enterprise Modular.
5252

@@ -56,11 +56,11 @@ Parameters
5656
log_type (optional, str, support_assist_collection)
5757
``application`` is applicable for OpenManage Enterprise Modular to export the application log bundle.
5858

59-
``support_assist_collection`` is applicable for one or more devices to export SupportAssist logs.
59+
``support_assist_collection`` and ``supportassist_collection`` is applicable for one or more devices to export SupportAssist logs.
6060

61-
``support_assist_collection`` supports both OpenManage Enterprise and OpenManage Enterprise Modular.
61+
``support_assist_collection`` and ``supportassist_collection`` supports both OpenManage Enterprise and OpenManage Enterprise Modular.
6262

63-
``support_assist_collection`` does not support export of ``OS_LOGS`` from OpenManage Enterprise. If tried to export, the tasks will complete with errors, and the module fails.
63+
``support_assist_collection`` and ``supportassist_collection`` does not support export of ``OS_LOGS`` from OpenManage Enterprise. If tried to export, the tasks will complete with errors, and the module fails.
6464

6565

6666
mask_sensitive_info (optional, bool, False)
@@ -70,15 +70,17 @@ Parameters
7070

7171

7272
log_selectors (optional, list, None)
73-
By default, the SupportAssist logs contains only hardware logs. To collect additional logs such as OS logs or RAID logs, specify these option in the choices list.
73+
By default, the SupportAssist logs contain only hardware logs. To collect additional logs such as OS logs, RAID logs or Debug logs, specify the log types to be collected in the choices list.
7474

75-
If not provided the default hardware log will be exported.
75+
If the log types are not specified, only the hardware logs are exported.
7676

7777
``OS_LOGS`` to collect OS Logs.
7878

7979
``RAID_LOGS`` to collect RAID controller logs.
8080

81-
This option is applicable only for ``support_assist_collection`` of *log_type*.
81+
``DEBUG_LOGS`` to collect Debug logs.
82+
83+
This option is applicable only for ``support_assist_collection`` and ``supportassist_collection`` of *log_type*.
8284

8385

8486
share_address (True, str, None)

‎docs/modules/redfish_storage_volume.rst

+2-1
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,8 @@ Notes
169169

170170
.. note::
171171
- Run this module from a system that has direct access to Redfish APIs.
172-
- This module does not support ``check_mode``.
172+
- This module supports ``check_mode``.
173+
- This module always reports changes when *name* and *volume_id* are not specified. Either *name* or *volume_id* is required to support ``check_mode``.
173174

174175

175176

‎galaxy.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
namespace: dellemc
22
name: openmanage
3-
version: 5.2.0
3+
version: 5.3.0
44
readme: README.md
55
authors:
66
- Rajeev Arakkal <Rajeev_Arakkal@Dell.com>

‎plugins/module_utils/utils.py

+15-4
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# -*- coding: utf-8 -*-
22

33
# Dell EMC OpenManage Ansible Modules
4-
# Version 5.2.0
4+
# Version 5.3.0
55
# Copyright (C) 2022 Dell Inc. or its subsidiaries. All Rights Reserved.
66

77
# Redistribution and use in source and binary forms, with or without modification,
@@ -123,14 +123,25 @@ def job_tracking(rest_obj, job_uri, max_job_wait_sec=600, job_state_var=('LastRu
123123
return job_failed, msg, job_dict, wait_time
124124

125125

126-
def get_rest_items(rest_obj, uri="DeviceService/Devices", key="Id", value="Identifier"):
126+
def get_rest_items(rest_obj, uri="DeviceService/Devices", key="Id", value="Identifier", selector="value"):
127127
item_dict = {}
128128
resp = rest_obj.get_all_items_with_pagination(uri)
129-
if resp.get("value"):
130-
item_dict = dict((item.get(key), item.get(value)) for item in resp["value"])
129+
if resp.get(selector):
130+
item_dict = dict((item.get(key), item.get(value)) for item in resp[selector])
131131
return item_dict
132132

133133

134+
def get_item_and_list(rest_obj, name, uri, key='Name', value='value'):
135+
resp = rest_obj.invoke_request('GET', uri)
136+
tlist = []
137+
if resp.success and resp.json_data.get(value):
138+
tlist = resp.json_data.get(value, [])
139+
for xtype in tlist:
140+
if xtype.get(key, "") == name:
141+
return xtype, tlist
142+
return {}, tlist
143+
144+
134145
def apply_diff_key(src, dest, klist):
135146
diff_cnt = 0
136147
for k in klist:

0 commit comments

Comments
 (0)