Fail fixes (#590)

Author: ShivamSh3

roles/idrac_attributes/molecule/default/converge.yml

@@ -112,7 +112,7 @@
         username: "{{ lookup('env', 'IDRAC_USER') }}"
         password: "{{ lookup('env', 'IDRAC_PASSWORD') }}"
         https_port: 443
-        ca_path: "/root/filedonotexits.pem"
+        ca_path: ""
         validate_certs: true
         idrac_attributes:
           SSH.1.Timeout: 1800

roles/idrac_bios/molecule/negative_scenarios_with_maintenance_window/converge.yml

@@ -49,7 +49,7 @@
           ansible.builtin.assert:
             that: "idrac_bios_out.attributes.status_msg is search('The
                   maintenance time must be post-fixed with local offset
-                  to -05:00.')"
+                  to -06:00.')"
 
     - name: Block to update attributes with maintenance window
             with invalid duration

roles/idrac_gather_facts/tests/asserts/virtualdisk_assert.yml

@@ -23,6 +23,10 @@
     api_response: "{{ virtualdisk_result.json | ansible.utils.remove_keys(target=['@odata.context', '@odata.type', '@odata.id', 'Actions',
       'EncryptionTypes@odata.count', 'Identifiers@odata.count', 'Links', 'Operations@odata.count', 'DellVirtualDisk', 'DellVirtualDisk@Redfish.Deprecated']) }}"
 
+- name: Set the keys diff
+  ansible.builtin.set_fact:
+    diff_keys: "{{ virtualdisk_data.keys() | list | symmetric_difference((api_response.keys() | list)) }}"
+
 - name: Set a Diff of dict
   ansible.builtin.set_fact:
     diff_data: "{{ diff_data | combine({item: virtualdisk_data[item]}) }}"

roles/idrac_import_server_config_profile/molecule/default/converge.yml

@@ -43,7 +43,8 @@
     - name: "Verifying Import SCP without scp_file"
       ansible.builtin.assert:
         that:
-          - "'Invalid file path provided.' in '{{ idrac_import_server_config_profile_out.msg }}'"
+          - "'Invalid file path provided.' in '{{ idrac_import_server_config_profile_out.msg }}' or
+            'HTTP Error 400: Bad Request' in '{{ idrac_import_server_config_profile_out.msg }}'"
 
     - name: "Importing SCP from CIFS with ALL components with invalid file"
       ansible.builtin.import_role:
@@ -64,7 +65,8 @@
     - name: "Verifying Import SCP from CIFS with ALL components with invalid file"
       ansible.builtin.assert:
         that:
-          - idrac_import_server_config_profile_out.msg == "Invalid file path provided."
+          - idrac_import_server_config_profile_out.msg == "Invalid file path provided." or
+            idrac_import_server_config_profile_out.msg == "Failed to import scp."
 
     - name: Wait for 15 seconds
       ansible.builtin.pause:
@@ -89,7 +91,8 @@
     - name: "Verifying Import SCP from CIFS with ALL components with invalid share"
       ansible.builtin.assert:
         that:
-          - "'HTTP Error 500' in '{{ idrac_import_server_config_profile_out.msg }}'"
+          - "'HTTP Error 500' in '{{ idrac_import_server_config_profile_out.msg }}' or
+            'Failed to import scp.' in '{{ idrac_import_server_config_profile_out.msg }}'"
 
     - name: "Importing SCP with invalid hostname"
       ansible.builtin.import_role:
@@ -203,7 +206,8 @@
     - name: "Verifying Import SCP with invalid username of share access"
       ansible.builtin.assert:
         that:
-          - idrac_import_server_config_profile_out.msg == "Invalid file path provided."
+          - idrac_import_server_config_profile_out.msg == "Invalid file path provided." or
+            idrac_import_server_config_profile_out.msg == "Failed to import scp."
 
     - name: "Importing SCP with invalid password of share access"
       ansible.builtin.import_role:
@@ -225,7 +229,8 @@
     - name: "Verifying Import SCP with invalid password of share access"
       ansible.builtin.assert:
         that:
-          - idrac_import_server_config_profile_out.msg == "Invalid file path provided."
+          - idrac_import_server_config_profile_out.msg == "Invalid file path provided." or
+            idrac_import_server_config_profile_out.msg == "Failed to import scp."
 
     - name: "Importing SCP with share_name as None"
       ansible.builtin.import_role:
@@ -297,4 +302,5 @@
     - name: "Verifying Import SCP with invalid proxy parameter"
       ansible.builtin.assert:
         that:
-          - idrac_import_server_config_profile_out.msg == "Invalid file path provided."
+          - idrac_import_server_config_profile_out.msg == "Invalid file path provided." or
+            idrac_import_server_config_profile_out.msg == "Failed to import scp."

roles/idrac_server_powerstate/molecule/default/converge.yml

@@ -54,7 +54,8 @@
     - name: Asserting after performing opeartion with invalid hostname
       ansible.builtin.assert:
         that:
-          - idrac_server_powerstate_out.msg == "<urlopen error [Errno -2] Name or service not known>"
+          - idrac_server_powerstate_out.msg == "<urlopen error [Errno -2] Name or service not known>" or
+            idrac_server_powerstate_out.msg == "<urlopen error Unable to resolve hostname or IP randomHostname:443.>"
 
     - name: Performing operation 'On' with invalid username
       ansible.builtin.import_role:

roles/redfish_firmware/molecule/negative/converge.yml

@@ -20,7 +20,8 @@
     - name: TC - 003 - Asserting wrong hostname
       ansible.builtin.assert:
         that:
-          - redfish_firmware_out.msg == "<urlopen error [Errno -2] Name or service not known>"
+          - redfish_firmware_out.msg == "<urlopen error [Errno -2] Name or service not known>" or
+            redfish_firmware_out.msg == "<urlopen error Unable to resolve hostname or IP randomHostname:443.>"
 
     - name: TC - 004 - Provide wrong username
       ansible.builtin.import_role: