Changes to make this compatible with running purely on a GPU #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wongjingping
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Checking if this an improved version of prompt.md? If so, shall we just replace the existing prompt.md with this?
| @@ -10,7 +10,7 @@ | |||
| if os.getenv("TOKENIZERS_PARALLELISM") is None: | |||
| os.environ["TOKENIZERS_PARALLELISM"] = "false" | |||
|
|
|||
| encoder = SentenceTransformer("sentence-transformers/all-MiniLM-L6-v2", device="cpu") | |||
| encoder = SentenceTransformer("sentence-transformers/all-MiniLM-L6-v2") | |||
There was a problem hiding this comment.
I was thinking of having a variable at the top of pruning.py called user_device, and then passing it to everywhere torch device is required. We can just check and set it once instead of checking/setting every place we create a tensor.
# at the top
user_device = "cuda" if torch.cuda.is_available() else "cpu"
encoder = SentenceTransformer("sentence-transformers/all-MiniLM-L6-v2", device=user_device)
...
query_emb = encoder.encode(query, convert_to_tensor=True, device=user_device)
...
column_emb = column_emb.to(user_device)The other benefit is that we can easily override user_device in tests to run only on cpu. wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not for merging just yet