Removing unnecessary if statement

[NourOM02]

In the eval.py file, the get_all_minimal_queries function contains an unnecessary if statement, when trying to replace the inside of the brackets when there is a GROUP BY statement, and it does look the same as saying if True:.

Lines of code:

# change group by size dynamically if necessary
if right.find("GROUP BY {}"):
    right = right.replace("GROUP BY {}", f"GROUP BY {column_str}")

The find method documentation:

Return the lowest index in the string where substring sub is found within the slice s[start:end]. Optional arguments start and end are interpreted as in slice notation. Return -1 if sub is not found.

Note : The find() method should be used only if you need to know the position of sub. To check if sub is a substring or not, use the in operator:

Description of the problem:

The find method is used to determine the presence of the string (not advised as per the python documentation). In addition to that, if GROUP BY {} is not in the string it will return -1 (which is not considered as False only 0 is). Furthermore, the replace method used in the inside will check the presence of the string anyway before replacing it. So why adding to the complexity of the code !?

Proposed edit:

# change group by size dynamically if necessary
right = right.replace("GROUP BY {}", f"GROUP BY {column_str}")

[rishsriv]

Thanks!