dcr: Make addresses returns more useable. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
ukane-philemon
approved these changes
Jan 2, 2025
|
Removed the erroneous comment https://github.com/decred/libwallet/compare/570e70e4cfa1f4455248262eeb560ca15c516de8..577c8bf37c9d54a3447ec61701520da1bef8ba6b Thanks for review @jrick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the internal addresses for anything. Cake also tells me we need some more unused addresses. This adjusts the addresses output to be more useful for us.
Returning all the used addresses was also problematic for potentially having too many return values.