Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui: Implement new style errors. #173

Closed
wants to merge 1 commit into from

Conversation

jholdstock
Copy link
Member

This PR implements the new error modals as defined by @MariaPleshkova in https://xd.adobe.com/view/a814493c-193a-4dfc-5735-0e6d459a6924-de25/

Also...

  • Account details page is now on its own path /account/{address}. Previously it made sense to have the account details and index page on the same path because they were two very similar pages, but now they have diverged quite significantly (eg. they each have their own templates).
  • The old path to check if an account exists has been renamed from /account to /account_exist
  • The modal backdrop is now the correct color as per the design spec.

@dnldd
Copy link
Member

dnldd commented Mar 30, 2020

Testing this right now, not seeing this modal show up when I search for fake address. I actually prefer the simple invalid address with the red underline that is currently there. Perhaps we should keep that?

@dnldd
Copy link
Member

dnldd commented Mar 30, 2020

This is what I'm seeing when i disable js:
no-js

I've synced the PR and rebuilt twice locally, let me know if I'm doing anything wrong here.

@jholdstock
Copy link
Member Author

The new modal is only used if you directly visit a URL which has an issue - for example /account/NotARealAddress. In this case, it is not practical to show the error under the text input.

When you are searching for an account using the AJAX form, the errors should be displayed as before. This PR does not change that.

This PR also does not change the Javascript warning - that will need some extra thought because it cannot be implemented as a modal - drawing a modal depends on Javascript. However, I am not able to recreate your left-aligned Javascript warning. On my screen that warning is centred and looks better.

@jholdstock
Copy link
Member Author

Closing - these changes will be included in #180 instead

@jholdstock jholdstock closed this Apr 8, 2020
@jholdstock jholdstock deleted the pagination3 branch October 6, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants