DE-6509: Kafka-Iceberg blog code #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rmoff
commented
Jun 6, 2024
rmoff
commented
- Build Kafka-Iceberg demo with Decodable
- Add ST config
- Add README
gunnarmorling
approved these changes
Jun 6, 2024
|
Why not this time? Declarative should be clearly better for this sort of stuff, so IMO we should use it for all new examples ideally from now on. |
|
because this blog has been sitting at 90% for weeks and I just need to ship the damn thing :) |
|
But then you could also spend that extra half day for making it perfect. Anyways, it's ok, that way we can make a separate post on Declarative, without stealing its thunder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.