Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafka ngrok example #12

Merged
merged 2 commits into from
May 8, 2024
Merged

Add kafka ngrok example #12

merged 2 commits into from
May 8, 2024

Conversation

rmoff
Copy link
Contributor

@rmoff rmoff commented May 8, 2024

No description provided.

@rmoff rmoff requested a review from gunnarmorling May 8, 2024 09:02
Copy link
Contributor

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Some minor comments inline. Taking a step back, we probably should look into re-organizing the examples, into more foundational things like this, vs. Decodable-specific stuff, etc.

curl -s localhost:4040/api/tunnels | jq -r '.tunnels[0].public_url' | sed 's/tcp:\/\///g'
----

WARNING: There is **NO SECURITY** defined on this Kafka cluster. Anyone scanning the ngrok address/port may find this and be able to access your data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to call this out. Alternatively, I have a set-up for basic auth here. Maybe worth adopting. Still not production-grade or anything, but it's at least not leaving the house completely unlocked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that setup work with the Confluent images?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, never used those ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk. for now I just wanna get this into the repo. maybe on the boston flight I will improve it :)

ZOOKEEPER_TICK_TIME: 2000

broker:
image: confluentinc/cp-kafka:7.5.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using the new official Apache image instead? And maybe no ZK?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. next time :) this is just to get it out the door.

@rmoff rmoff requested a review from gunnarmorling May 8, 2024 09:41
Copy link
Contributor

@gunnarmorling gunnarmorling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some room for potential future improvements ;)

@rmoff
Copy link
Contributor Author

rmoff commented May 8, 2024

canadian-thank-you-gif-by-netflix

@rmoff rmoff merged commit 7d734eb into main May 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants