[controller] Fix the cache freezed Bound PVC #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorKram
force-pushed
the
v-kramarenko-fix-cache
branch
2 times, most recently
from
b252977 to
3dfd94c
Compare
ViktorKram
changed the title
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
ViktorKram
force-pushed
the
v-kramarenko-fix-cache
branch
2 times, most recently
from
3aceed3 to
54a6256
Compare
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
ViktorKram
force-pushed
the
v-kramarenko-fix-cache
branch
from
54a6256 to
bcc10bb
Compare
AleksZimin
approved these changes
Sep 26, 2024
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
astef
reviewed
Sep 26, 2024
images/sds-local-volume-scheduler-extender/src/pkg/cache/cache.go
Outdated
Show resolved
Hide resolved
astef
reviewed
Sep 26, 2024
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
astef
reviewed
Sep 26, 2024
astef
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the issue where a Bound PVC could get stuck in the cache due to the LVGCacheWatcher executing earlier than the PVCCacheWatcher, causing the PVC to be updated to status Bound after the clearing operation.
Now, there is a special algorithm that monitors for expired and Bound PVCs in the cache and removes them. Users can specify the desired expiration time through the sds-local-volume-scheduler configuration.
Why do we need it, and what problem does it solve?
Due to this bug, some Pods might not have been scheduled correctly due to inaccurate node free space counting.
What is the expected result?
No freezed PVC in the cache, everything works fine.
Checklist