-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[controller] Merge cmd subpackage into main #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
99f25b4
to
7a681b5
Compare
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
ViktorKram
approved these changes
Sep 5, 2024
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
ead916f
to
e289a27
Compare
Signed-off-by: Alexandr Stefurishin <alexandr.stefurishin@flant.com>
AleksZimin
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scope of the change is
sds-local-volume-scheduler-extender
. My goal is refactoring, not changing the behavior, but a few edge case scenarios has been fixed.cmd
subpackage intomain
extendsds-local-volume-scheduler-extender/pkg/logger
with options to remove repetetive[subMain]
logger name prefixif err := foo(); err != nil {
) where possibleos.Exit(1)
with errors, since former doesn't executedefer
(may lead to accidental resource leakage in future)SilenceErrors = true
to avoid printing error twice (once by us and another one by cobra)SIGINT
signal, for shutdown to work from terminalWriteTimeout
forhttp.Server
to avoid indefinite wait for slow clients during shutdownBaseContext
to Runnables managed by the ManagerWhy do we need it, and what problem does it solve?
Code becomes cleaner, and a few minor edge-case problems has been fixed.
What is the expected result?
Behavior should not change
Checklist