[controller] Refactor code on linter issues and test improvements. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorKram
force-pushed
the
v-kramarenko-linster-fixes
branch
from
69243b0 to
e624485
Compare
ViktorKram
force-pushed
the
v-kramarenko-linster-fixes
branch
3 times, most recently
from
13ef205 to
567a3d0
Compare
duckhawk
approved these changes
Aug 12, 2024
AleksZimin
approved these changes
Aug 13, 2024
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com> Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
force-pushed
the
v-kramarenko-linster-fixes
branch
from
567a3d0 to
9b73944
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring on linter issues and test improvements.
Why do we need it, and what problem does it solve?
More accurate and test-coverage code.
What is the expected result?
Linters do not fail and tests run successfully.
Checklist