Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Use models from separate module #51

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

duckhawk
Copy link
Member

@duckhawk duckhawk commented Jul 5, 2024

Description

We move models from folder in repo to separate module

Why do we need it, and what problem does it solve?

We need this for code unification and reduce possible errors

What is the expected result?

Golang code unification

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@duckhawk duckhawk added the enhancement New feature or request label Jul 5, 2024
@duckhawk duckhawk requested review from dxavx and ViktorKram July 5, 2024 07:15
@duckhawk duckhawk self-assigned this Jul 5, 2024
@duckhawk duckhawk force-pushed the switch-to-module-api branch 4 times, most recently from 3d8e439 to 4bb78cc Compare July 5, 2024 07:49
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
@duckhawk duckhawk force-pushed the switch-to-module-api branch from e13ed77 to f5b8d74 Compare July 5, 2024 12:19
@duckhawk duckhawk merged commit 7e8f35e into main Jul 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants