[controller] Add AllocationLimit feature support #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
ViktorKram
force-pushed
the
v-kramarenko-adds-allocation-limit
branch
from
4ae1624 to
77b627c
Compare
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
ViktorKram
force-pushed
the
v-kramarenko-adds-allocation-limit
branch
5 times, most recently
from
9b78b49 to
e21adc9
Compare
ViktorKram
changed the title
ViktorKram
force-pushed
the
v-kramarenko-adds-allocation-limit
branch
from
e21adc9 to
c0dcd6d
Compare
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
ViktorKram
force-pushed
the
v-kramarenko-adds-allocation-limit
branch
from
c0dcd6d to
8f988ad
Compare
dxavx
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a support for an AllocationLimit feature. It allows users to manage LVMVolumeGroup thin-pool's available space through the AllocationLimit field, so they can easily decrease or increase the amount of thin LV using the thin-pools.
The controller will filter and score the nodes according to the AllocationLimit value.
Why do we need it, and what problem does it solve?
It prevents unexpected and unmanageable Thin LV creations and disk space overuse.
What is the expected result?
The controller filters and scores the nodes for Thin LVs correctly according to AllocationLimit value.
Thin LVs with requested size more than available thin pool space, should not be created (but might become such, if a user increase the AllocationLimit value).
Checklist