[controller] Remove isDefault field and refactor some logic in lsc controller #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
dxavx
approved these changes
May 3, 2024
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
force-pushed
the
fix-crd-remove-default-and-filesystem
branch
3 times, most recently
from
bf78c1c to
1e4f07c
Compare
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
force-pushed
the
fix-crd-remove-default-and-filesystem
branch
from
8217c85 to
53ea17d
Compare
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
force-pushed
the
fix-crd-remove-default-and-filesystem
branch
from
986de33 to
82c43d7
Compare
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin
force-pushed
the
fix-crd-remove-default-and-filesystem
branch
from
3cac2d6 to
d95800a
Compare
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
isDefaultfield and refactors some logic in thelsccontroller to simplify and enhance code efficiency.Why do we need it, and what problem does it solve?
The removal of the
isDefaultfield aims to improve the user experience. This change allows users to leverage the standard Kubernetes mechanism for defining the default StorageClass by using annotations.The refactoring of logic in the
lsccontroller aim to simplify the codebase.What is the expected result?
Checklist