Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Add a webhook to validate storage class operations #36

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

ViktorKram
Copy link
Contributor

@ViktorKram ViktorKram commented Apr 25, 2024

Description

Added a webhook to prevent manual operations with Storage Classes with the module provisioner.

Why do we need it, and what problem does it solve?

This webhook prevents unexpected behavior of LocalStorageClass controller in cases when StorageClasses were changed manually by a user.

What is the expected result?

Storage Classes with the module provisioner might not be managed manually by a user.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@ViktorKram ViktorKram added the enhancement New feature or request label Apr 25, 2024
@ViktorKram ViktorKram requested review from dxavx and AleksZimin April 25, 2024 13:20
@ViktorKram ViktorKram self-assigned this Apr 25, 2024
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
@ViktorKram ViktorKram force-pushed the v-kramarenko-adds-webhook branch from 22ec938 to 04375ed Compare April 25, 2024 14:21
ViktorKram and others added 5 commits April 25, 2024 18:01
Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin AleksZimin merged commit f135ad4 into main Apr 26, 2024
3 checks passed
@AleksZimin AleksZimin deleted the v-kramarenko-adds-webhook branch April 26, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants