-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[csi] Add NodeStageVolume and NodeUnstageVolume #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17e2706
to
97d21cb
Compare
dxavx
approved these changes
Apr 15, 2024
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
4939353
to
adbc80c
Compare
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
dxavx
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
NodeStageVolume
andNodeUnstageVolume
methods to our CSI driver. These methods enhance the handling of multi-attach scenarios for the same volume across multiple containers. Specifically,NodeStageVolume
is responsible for preparing the volume, including filesystem creation (if needed) and performing the initial mount. Subsequently, theNodePublishVolume
step performs a bind mount to make the volume available to the container. To ensure thread safety and prevent concurrent processing issues, we have also implemented a map that tracks volumes currently being processed.Why do we need it, and what problem does it solve?
Adding
NodeStageVolume
andNodeUnstageVolume
addresses the challenge of correctly managing volumes that are attached to multiple containers simultaneously, particularly in filesystem mode. Previously, handling simultaneous attachments could lead to errors or race conditions, especially when operations like filesystem creation were involved. By separating the mount and bind mount stages and introducing a tracking mechanism for volume processing, we enhance the robustness and reliability of our volume management.What is the expected result?
Checklist