Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Add LocalStorageClass validation webhook #20

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

duckhawk
Copy link
Member

@duckhawk duckhawk commented Mar 22, 2024

Description

Add LocalStorageClass validation webhook

Why do we need it, and what problem does it solve?

We must prevent user from incorrect LocalStorageClasses configurations

What is the expected result?

Working LocalStorageClassess implementation

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@duckhawk duckhawk added the enhancement New feature or request label Mar 22, 2024
@duckhawk duckhawk self-assigned this Mar 22, 2024
@duckhawk duckhawk requested a review from AleksZimin March 22, 2024 07:44
@duckhawk duckhawk force-pushed the add-sc-validation-webhook branch 3 times, most recently from 4a0a76a to c3cde56 Compare March 22, 2024 15:07
@duckhawk duckhawk marked this pull request as ready for review March 22, 2024 15:08
Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
@duckhawk duckhawk force-pushed the add-sc-validation-webhook branch from c3cde56 to 0bc6942 Compare March 27, 2024 06:28
@AleksZimin AleksZimin changed the title Add LocalStorageClass validation webhook [controller] Add LocalStorageClass validation webhook Mar 27, 2024
@AleksZimin AleksZimin merged commit 1d05d65 into main Mar 27, 2024
3 checks passed
@AleksZimin AleksZimin deleted the add-sc-validation-webhook branch March 27, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants