Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csi] Add field ActualLVNameOnTheNode. Add SDSLocalVolumeCSIFinalizer. Add delete LVMLogicalVolume after error in CreateVolume. Bump go builder to 1.21 #18

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

AleksZimin
Copy link
Member

@AleksZimin AleksZimin commented Mar 6, 2024

Description:

This PR introduces several enhancements and fixes:

  • ActualLVNameOnTheNode Field: Synchronized the ActualLVNameOnTheNode field in the LVMLogicalVolume spec with the design documentation to ensure consistency.
  • SDSLocalVolumeCSIFinalizer: Implemented a dedicated finalizer for CSI within LVMLogicalVolume to prevent the deletion of Logical Volumes (LV) on nodes if the CSI finalizer has not been removed. This addition aims to enhance the management and cleanup of resources.
  • Deletion of LVMLogicalVolume on CreateVolume Error: Added logic to delete the LVMLogicalVolume resource if an error occurs during the CreateVolume operation, improving error handling and resource cleanup.
  • Go Builder Version Bump to 1.21: Updated the Go builder version to 1.21 to leverage new Go features and improvements.

What is the expected result?

  • Improved consistency between the LVMLogicalVolume spec and design documentation.
  • Enhanced resource lifecycle management with the new finalizer, preventing premature LV deletions.
  • Better error handling through automatic cleanup of resources upon failure in volume creation.
  • Utilization of Go 1.21 features for development, resulting in more efficient and reliable code.

Checklist:

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin AleksZimin changed the title [csi] Add field ActualLVNameOnTheNode. Add SDSLocalVolumeCSIFinalize. Add delete LVMLogicalVolume after error in CreateVolume [csi] Add field ActualLVNameOnTheNode. Add SDSLocalVolumeCSIFinalizer. Add delete LVMLogicalVolume after error in CreateVolume Mar 7, 2024
@AleksZimin AleksZimin changed the title [csi] Add field ActualLVNameOnTheNode. Add SDSLocalVolumeCSIFinalizer. Add delete LVMLogicalVolume after error in CreateVolume [csi] Add field ActualLVNameOnTheNode. Add SDSLocalVolumeCSIFinalizer. Add delete LVMLogicalVolume after error in CreateVolume. Bump go builder to 1.21 Mar 7, 2024
@AleksZimin AleksZimin self-assigned this Mar 7, 2024
@AleksZimin AleksZimin requested a review from dxavx March 7, 2024 10:46
@AleksZimin AleksZimin added the enhancement New feature or request label Mar 7, 2024
@AleksZimin AleksZimin marked this pull request as ready for review March 7, 2024 10:46
@AleksZimin AleksZimin requested a review from ViktorKram March 7, 2024 10:46
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@ViktorKram ViktorKram self-requested a review March 7, 2024 13:50
@AleksZimin AleksZimin merged commit 4ef1829 into main Mar 7, 2024
3 checks passed
@AleksZimin AleksZimin deleted the fix-llv-fields branch March 7, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants