[contoller] Add a possibility to edit a LocalStorageClass spec.lvm.LVMVolumeGroups to configure an appropriate Storage Class. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxavx
approved these changes
Mar 6, 2024
ViktorKram
force-pushed
the
v-kramarenko-adds-new-logic-to-lsc
branch
from
d14a68a to
2ea1362
Compare
… corresponding Storage Class Signed-off-by: Viktor Kramarenko <viktor.kramarenko@flant.com>
ViktorKram
force-pushed
the
v-kramarenko-adds-new-logic-to-lsc
branch
from
2ea1362 to
5a3c4e2
Compare
AleksZimin
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a possibility to edit a LocalStorageClass spec.lvm.LVMVolumeGroups resources to configure an appropriate Storage Class.
Now if the resource validation fails, the controller will add a request to requeue until the resource is fixed or deleted.
Why do we need it, and what problem does it solve?
A user has a possibility to change LVMVolumeGroups using by a Storage Class.
If a user fixes the LocalStorageClass validation failure, the controller will continue the work automatically.
What is the expected result?
A LocalStorageClass spec.lvm.LVMVolumeGroups editing provides an appropriate Storage Class recreation with actual LVMVolumeGroups.
If the validation of the Local Storage Class resource fails, the controller will retry processing the resource until it succeeds or the problematic resource is deleted.
Checklist