Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[grafana] Dashboards content validations improvements #300

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

ghostinsoba
Copy link
Contributor

Description

Additional validations is required:

  • Check if datasource uid specified correctly
    (legacy, before Grafana 8.3: "datasource": "$datasource_uid", after "datasource": {"uid": "$datasource_uid"})

  • Check if panel type is not deprecated
    (recommend to migrate from graph (old) to timeseries and from flant-statusmap-panel to state-timeline)

Changed existing flant-statusmap-panel deprecation recommendations from status-history to state-timeline

Why do we need it, and what problem does it solve?

Closes #8038

What is the expected result?

CI must fail for new pull requests that contain dashboards with deprecated forms of datasource UIDs and panel types

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: testing
type: chore
summary: Dashboard linter improvements.
impact_level: low

Signed-off-by: ghostinsoba <125242947+ghostinsoba@users.noreply.github.com>
Signed-off-by: ghostinsoba <125242947+ghostinsoba@users.noreply.github.com>
@ghostinsoba ghostinsoba merged commit fbfeeb1 into main Apr 15, 2024
24 of 27 checks passed
@ghostinsoba ghostinsoba deleted the feat/grafana-dashboards-validator-improvements branch April 15, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant