Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[csi] Add volumeCleanup #73

Merged
merged 40 commits into from
Feb 21, 2025
Merged

[csi] Add volumeCleanup #73

merged 40 commits into from
Feb 21, 2025

Conversation

AleksZimin
Copy link
Member

@AleksZimin AleksZimin commented Feb 1, 2025 •
edited by duckhawk
Loading

Description

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@AleksZimin AleksZimin added the enhancement New feature or request label Feb 1, 2025
@AleksZimin AleksZimin self-assigned this Feb 1, 2025
asergunov
asergunov reviewed Feb 3, 2025
View reviewed changes
@AleksZimin AleksZimin changed the title data wipe [csi] Add volumeCleanup Feb 13, 2025
AleksZimin and others added 9 commits February 13, 2025 21:44
@AleksZimin
first commit
39469fb 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
some fixes
24007be 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
test
62a7554 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
prepare for tests
e273359 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@asergunov @AleksZimin
Вариант документации.
d66bd0b 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@asergunov @AleksZimin
Punch or zero out
9b02809 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
08333d1 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
f20f0c3 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
54fc655 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
add shred
7fcb624 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
some changes
486d81d 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
1198d9e 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fixes
e5c53c6 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
1305c3a 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
f4464f2 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
bump deps
081dd90 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
some changes
664da6d 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
a54942b 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
2e59e5d 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
ff4d6ef 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
4bcd465 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
c27c088 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
84682a4 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
915aa1e 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix nsc
8895f0f 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
3e4266e 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
AleksZimin and others added 11 commits February 15, 2025 01:01
@AleksZimin
some fixes
7b752b5 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
df0585d 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
25c0b2a 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fixes after review
dd32f7e 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
some commit
b53a2db 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
finish refactoring
567df94 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
add vsclass
461ad60 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix linter
e1f4a13 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix rbac
5439265 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin
fix
bfc2df1 
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@asergunov
remove ZERO_RANGE from doc
23db42c 
Signed-off-by: Anton Sergunov <anton.sergunov@flant.com>
denmaloyreb
denmaloyreb reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@denmaloyreb denmaloyreb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translation and description of the volumeCleanup parameter
for the Russian version will be added after accepting these suggestions.

duckhawk and others added 2 commits February 20, 2025 16:56
@duckhawk @denmaloyreb
Apply suggestions from code review
0c6eae4 
Co-authored-by: Denis Rebenok <60424108+denmaloyreb@users.noreply.github.com>
Signed-off-by: Vasily Oleynikov <archi.kun@gmail.com>
docs: add volumeCleanup description (ru CRD) and Selects the method t…
dfc0b60 
…o clean the volume before deleting the PV section in readme

Signed-off-by: Denis.Rebenok <denis.rebenok@flant.ru>
denmaloyreb
denmaloyreb previously approved these changes Feb 21, 2025
View reviewed changes
denmaloyreb
denmaloyreb reviewed Feb 21, 2025
View reviewed changes
@duckhawk @denmaloyreb
Apply suggestions from code review
56c0f7d 
Co-authored-by: Denis Rebenok <60424108+denmaloyreb@users.noreply.github.com>
Signed-off-by: Vasily Oleynikov <archi.kun@gmail.com>
@duckhawk duckhawk marked this pull request as ready for review February 21, 2025 10:45
@duckhawk duckhawk self-requested a review February 21, 2025 10:45
@duckhawk duckhawk merged commit 64bc17f into main Feb 21, 2025
8 checks passed
@duckhawk duckhawk deleted the azimin-add-data-wipe branch February 21, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astef astef astef left review comments

@asergunov asergunov asergunov left review comments

@denmaloyreb denmaloyreb denmaloyreb left review comments

@duckhawk duckhawk duckhawk approved these changes

Assignees

@AleksZimin AleksZimin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AleksZimin @astef @asergunov @duckhawk @denmaloyreb