Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[controller] Remove subDir parameter from NFSStorageClass #10

Merged
merged 4 commits into from
May 16, 2024

Conversation

AleksZimin
Copy link
Member

@AleksZimin AleksZimin commented May 16, 2024

Description

This PR removes the subDir parameter from the NFSStorageClass configuration and related code. This change aims to simplify the configuration process and reduce the likelihood of configuration errors.

Why do we need it, and what problem does it solve?

Removing the subDir parameter helps streamline the configuration of NFSStorageClass, making it easier for users to set up and manage their storage classes. By eliminating this parameter, we reduce the complexity of the configuration, thereby minimizing the chances of misconfigurations and improving the overall user experience.

What is the expected result?

  • Simplified NFSStorageClass configuration without the subDir parameter.
  • Reduced risk of configuration errors.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin AleksZimin self-assigned this May 16, 2024
@AleksZimin AleksZimin changed the title [controller] Remove subDir paramater [controller] Remove subDir parameter May 16, 2024
@AleksZimin AleksZimin changed the title [controller] Remove subDir parameter [controller] Remove subDir parameter from NFSStorageClass May 16, 2024
@AleksZimin AleksZimin added the enhancement New feature or request label May 16, 2024
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
Signed-off-by: Aleksandr Zimin <alexandr.zimin@flant.com>
@AleksZimin AleksZimin merged commit 4cf0b35 into main May 16, 2024
3 checks passed
@AleksZimin AleksZimin deleted the remove-snaphots-crds-and-subdir branch May 16, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant