fix: prevent garbage collection from removing default profiles #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braianj
approved these changes
Feb 28, 2025
|
|
||
| it('should not garbage collect default profiles even when they are old', async () => { | ||
| const timestamp = Date.now() - PROFILE_DURATION * 2 | ||
| const defaultProfile = await buildDeployData(['default123'], { |
There was a problem hiding this comment.
WDYT about setting const those string, maybe a beforeEach?
Suggested change
| const defaultProfile = await buildDeployData(['default123'], { | |
| const defaultProfile = await buildDeployData([PROFILE[1]], { |
Comment on lines
+252
to
+253
| 'test/integration/resources/some-binary-file.png', | ||
| 'test/integration/resources/some-text-file.txt' |
Comment on lines
+259
to
+263
| const regularProfile = await buildDeployData(['0x000000000'], { | ||
| type: EntityType.PROFILE, | ||
| contentPaths: [ | ||
| 'test/integration/resources/some-binary-file.png', | ||
| 'test/integration/resources/some-text-file.txt' |
There was a problem hiding this comment.
and here
Suggested change
| const regularProfile = await buildDeployData(['0x000000000'], { | |
| type: EntityType.PROFILE, | |
| contentPaths: [ | |
| 'test/integration/resources/some-binary-file.png', | |
| 'test/integration/resources/some-text-file.txt' | |
| const regularProfile = await buildDeployData([PROFILE[2]], { | |
| type: EntityType.PROFILE, | |
| contentPaths: [ | |
| URL[0], URL[1] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents the garbage collection from removing default profiles from the database whenever it runs.