Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clear stale profiles #1729

Merged
merged 15 commits into from
Feb 19, 2024
Merged

chore: clear stale profiles #1729

merged 15 commits into from
Feb 19, 2024

Conversation

hugoArregui
Copy link
Contributor

@hugoArregui hugoArregui commented Jan 30, 2024

Approach

GC

The GC process will run no matter the status of the GARBAGE_COLLECTION flag. It will:

  1. it will clean the old profiles active entities, which means:
    1. it will delete the old profiles (+1year) from the active entities cache
    2. it will delete the old profiles (+1year) from the active pointers table
  2. if GARBAGE_COLLECTION is enabled, it will remove the old profiles deployments, the content_files's table entries for those deployments, and the files themselves if they are not used by a newer profile (<1 year)
  3. if GARBAGE_COLLECTION is enabled, it will run the old GC as well

Sync

No old profiles will be synced, even if they are included in a snapshot

@hugoArregui hugoArregui changed the title chore: stale profiles chore: clear stale profiles Feb 1, 2024
@hugoArregui hugoArregui requested a review from aleortega February 5, 2024 13:14
Copy link
Contributor

@marianogoldman marianogoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good!

@hugoArregui hugoArregui marked this pull request as ready for review February 9, 2024 12:11
@hugoArregui hugoArregui enabled auto-merge (squash) February 19, 2024 14:01
@hugoArregui hugoArregui merged commit 4a40f7f into main Feb 19, 2024
7 of 9 checks passed
@hugoArregui hugoArregui deleted the stale-profiles branch February 19, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants