Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deploy to world without complete name #3264

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

LautaroPetaccio
Copy link
Contributor

This PR fixes the subdomain property that is used when deploying DCL names by adding the dcl.eth at the end of the domain.

Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 8:35pm

@LautaroPetaccio LautaroPetaccio merged commit d9b95c0 into master Mar 7, 2025
7 checks passed
@LautaroPetaccio LautaroPetaccio deleted the fix/deploy-to-dcl-world branch March 7, 2025 20:38
@coveralls
Copy link

coveralls commented Mar 7, 2025

Pull Request Test Coverage Report for Build 13728809531

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.838%

Totals Coverage Status
Change from base Build 13597075231: 0.0%
Covered Lines: 5986
Relevant Lines: 11264

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants