sync/v4 expects to return an empty root instead of 404 #327
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SohnyBohny
reviewed
Oct 19, 2024
|
|
||
| func (app *App) syncGetRootV4(c *gin.Context) { | ||
| app.syncGetRoot(c, func(c *gin.Context) { | ||
| c.JSON(http.StatusOK, messages.SyncRootV3Response{ |
There was a problem hiding this comment.
Suggested change
| c.JSON(http.StatusOK, messages.SyncRootV3Response{ | |
| c.JSON(http.StatusOK, messages.SyncRootV3Request{ |
Got it to work after changing this line.
There was a problem hiding this comment.
It doesn't make sense to respond with a Request. It must be something else.
The difference will be:
{
"generation": 0,
"schemaVersion": 0
}to:
{
"generation": 0,
"broadcast": false
}Perhaps adding the correct schemaVersion as seen in the rest of the code?
Open
|
@ddvk stop! Did you test? For me this PR did not work but needed an additional fix, see #327 (comment) Should I open a new PR? |
|
ah, sorry. I'm trying to fix something else (3.15), so I just merged it with the idea of fixing it as well if not ok |
ddvk
added a commit
that referenced
this pull request
Nov 15, 2024
|
@SohnyBohny You can try the master again, should work with empty cloud (tested on 3.15.4.2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch, I tried do fix issues reported on the initial synchronization, when the account is new and no sync happen before.
I was able to test the creation of a new account with the sync/v3, it works as expected, but the changes between v3 and v4 seems to be related to how the function behaves for new accounts: #311 (comment) #326 #270 (comment)