Preserve stdin backward compatibility #804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromedalbert
changed the title
|
Just tweaked #803 a bit more and included this functionality for backwards-compatibility. Thanks for pointing it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you plan on keeping backward compatibility for feature #803?
If you don't then please close this PR. This means that after upgrading Foreman,
foreman startwill not boot for users whose Procfile containstailwindcss --watchoresbuild --watchor any other process that needs an open stdin. They will have to switch totailwindcss --watch=always,esbuild --watch=forever, or whatever hack they can find (if any) to make their setup work again.If you plan on keeping backward compatibility, then this PR only closes stdin if the
--interactiveoption is supplied. Otherwise it keeps the original behavior of keeping stdin open.