-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude "distinct from" from hard coded references flag #411
Conversation
Yeahh, regexes to review! |
@graciegoheen did you make changes to the seeds at all to catch this new model? |
@dave-connors-3 No just added this to
|
@graciegoheen ah i see i guess we would indeed not expect a new violation there lol |
select | ||
* | ||
from {{ ref('fct_model_9') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this edit needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ugh come on
This is a:
Link to Issue
Closes #338
Description & motivation
SQL that uses
is distinct from
oris not distinct from
is being incorrectly flagged as a hard coded reference.Example:
new.ALL_SOURCE_ATTRIBUTES
is being flagged.I added a negative lookback for
distinct
to all regex checks.Integration Test Screenshot
Checklist