Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model version information to int_all_dag_relationships #478

Closed
schicks opened this issue Aug 2, 2024 · 2 comments
Closed

Add model version information to int_all_dag_relationships #478

schicks opened this issue Aug 2, 2024 · 2 comments
Labels
enhancement New feature or request triage

Comments

@schicks
Copy link

schicks commented Aug 2, 2024

Describe the feature

I want to be able to write a test saying that some set of models (public models, models with cross project dependencies, etc.; can imagine a few different ways to slice it) must be versioned. Currently there is not version data in int_all_dag_relationships, which makes this hard to write, but if there were version data exposed via one of the models in this package it would become fairly easy to write.

Describe alternatives you've considered

I explored making the warning for breaking contract changes into an error as an alternative. However, because this is set as a flag it is not feasible to configure in a flexible enough way. The goal here is to enforce this rule on a subset of models for whom breaking changes are high risk because they are consumed by other teams or projects deployed separately. As a flag, we either have to enforce it on all models or no models.

Additional context

I don't think the DB matters here, but I use bigquery.

Who will this benefit?

The primary goal would be to make it easier and safer to manage multi project systems, by enforcing at an organizational level (through a shared dbt package) that any model you are consuming from another project will not break their existing contract within a version. This enforces the standard software best practice that is commonplace for code packages.

Are you interested in contributing this feature?

I would be happy to contribute, but would need advice on where and how to make this change.

@schicks schicks added enhancement New feature or request triage labels Aug 2, 2024
@dave-connors-3
Copy link
Collaborator

hey @schicks ! thanks opening the issue. did you take a look at int_all_graph_resources by chance? I believe we include version info here, and you could likely join across the two models to develop this test!

@schicks
Copy link
Author

schicks commented Aug 2, 2024

Amazing! That seems like exactly what I'm looking for. Thank you!

@schicks schicks closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants