Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependencies + golang to 1.21.11 #23

Merged
merged 2 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Set up Go 1.20.x
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version-file: './go.mod'
Expand Down
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ variables:
TYPE: app
MULTI_ARCH: "true"

image: golang:1.20
image: golang:1.21.11
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't you think 1:21 would be okay? i dont see the benefit of specifying the patch version here


include:
- project: shared-scripts/gitlab-ci
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=$BUILDPLATFORM golang:1.20-alpine as builder
FROM --platform=$BUILDPLATFORM golang:1.21.11-alpine as builder

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here. 1.21 is okay imo

ARG RELEASE_VERSION=development

Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
all: build test

version := v1.27.0-0
version := v1.28.0-0

build:
go build -o bin/thundering-herd-scheduler ./cmd/thundering-herd-scheduler/main.go
Expand All @@ -23,7 +23,7 @@ test:
go test ./...

docker:
docker buildx build -t thundering-herd-scheduler:local --build-arg RELEASE_VERSION=v1.0.0-beta .
docker buildx build -t thundering-herd-scheduler:local --load --build-arg RELEASE_VERSION=${version} .

local:
bin/thundering-herd-scheduler --config manifests/development/scheduler.yaml
94 changes: 47 additions & 47 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
module github.com/dbschenker/thundering-herd-scheduler

go 1.20
go 1.21.11

require (
github.com/benbjohnson/clock v1.3.5
k8s.io/api v0.28.8
k8s.io/apimachinery v0.28.8
k8s.io/client-go v0.28.8
k8s.io/component-base v0.28.8
k8s.io/api v0.28.9
k8s.io/apimachinery v0.28.9
k8s.io/client-go v0.28.9
k8s.io/component-base v0.28.9
k8s.io/klog/v2 v2.120.1
k8s.io/kubernetes v1.28.8
k8s.io/kubernetes v1.28.9
)

require (
Expand Down Expand Up @@ -110,17 +110,17 @@ require (
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
k8s.io/apiextensions-apiserver v0.0.0 // indirect
k8s.io/apiserver v0.28.8 // indirect
k8s.io/cloud-provider v0.28.8 // indirect
k8s.io/component-helpers v0.28.8 // indirect
k8s.io/controller-manager v0.28.8 // indirect
k8s.io/csi-translation-lib v0.28.8 // indirect
k8s.io/dynamic-resource-allocation v0.28.8 // indirect
k8s.io/kms v0.28.8 // indirect
k8s.io/apiserver v0.28.9 // indirect
k8s.io/cloud-provider v0.28.9 // indirect
k8s.io/component-helpers v0.28.9 // indirect
k8s.io/controller-manager v0.28.9 // indirect
k8s.io/csi-translation-lib v0.28.9 // indirect
k8s.io/dynamic-resource-allocation v0.28.9 // indirect
k8s.io/kms v0.28.9 // indirect
k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9 // indirect
k8s.io/kube-scheduler v0.28.8 // indirect
k8s.io/kubelet v0.28.8 // indirect
k8s.io/mount-utils v0.28.8 // indirect
k8s.io/kube-scheduler v0.28.9 // indirect
k8s.io/kubelet v0.28.9 // indirect
k8s.io/mount-utils v0.28.9 // indirect
k8s.io/utils v0.0.0-20240310230437-4693a0247e57 // indirect
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.28.5 // indirect
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
Expand All @@ -129,40 +129,40 @@ require (
)

replace (
k8s.io/api => k8s.io/api v0.28.8
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.28.8
k8s.io/apimachinery => k8s.io/apimachinery v0.28.8
k8s.io/apiserver => k8s.io/apiserver v0.28.8
k8s.io/cli-runtime => k8s.io/cli-runtime v0.28.8
k8s.io/client-go => k8s.io/client-go v0.28.8
k8s.io/cloud-provider => k8s.io/cloud-provider v0.28.8
k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.28.8
k8s.io/code-generator => k8s.io/code-generator v0.28.8
k8s.io/component-base => k8s.io/component-base v0.28.8
k8s.io/component-helpers => k8s.io/component-helpers v0.28.8
k8s.io/controller-manager => k8s.io/controller-manager v0.28.8
k8s.io/cri-api => k8s.io/cri-api v0.28.8
k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.28.8
k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.28.8
k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.28.8
k8s.io/kube-proxy => k8s.io/kube-proxy v0.28.8
k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.28.8
k8s.io/kubectl => k8s.io/kubectl v0.28.8
k8s.io/kubelet => k8s.io/kubelet v0.28.8
k8s.io/kubernetes => k8s.io/kubernetes v1.28.8
k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.28.8
k8s.io/metrics => k8s.io/metrics v0.28.8
k8s.io/mount-utils => k8s.io/mount-utils v0.28.8
k8s.io/pod-security-admission => k8s.io/pod-security-admission v0.28.8
k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.28.8
k8s.io/api => k8s.io/api v0.28.9
k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.28.9
k8s.io/apimachinery => k8s.io/apimachinery v0.28.9
k8s.io/apiserver => k8s.io/apiserver v0.28.9
k8s.io/cli-runtime => k8s.io/cli-runtime v0.28.9
k8s.io/client-go => k8s.io/client-go v0.28.9
k8s.io/cloud-provider => k8s.io/cloud-provider v0.28.9
k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.28.9
k8s.io/code-generator => k8s.io/code-generator v0.28.9
k8s.io/component-base => k8s.io/component-base v0.28.9
k8s.io/component-helpers => k8s.io/component-helpers v0.28.9
k8s.io/controller-manager => k8s.io/controller-manager v0.28.9
k8s.io/cri-api => k8s.io/cri-api v0.28.9
k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.28.9
k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.28.9
k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.28.9
k8s.io/kube-proxy => k8s.io/kube-proxy v0.28.9
k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.28.9
k8s.io/kubectl => k8s.io/kubectl v0.28.9
k8s.io/kubelet => k8s.io/kubelet v0.28.9
k8s.io/kubernetes => k8s.io/kubernetes v1.28.9
k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.28.9
k8s.io/metrics => k8s.io/metrics v0.28.9
k8s.io/mount-utils => k8s.io/mount-utils v0.28.9
k8s.io/pod-security-admission => k8s.io/pod-security-admission v0.28.9
k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.28.9
)

replace k8s.io/sample-cli-plugin => k8s.io/sample-cli-plugin v0.28.8
replace k8s.io/sample-cli-plugin => k8s.io/sample-cli-plugin v0.28.9

replace k8s.io/sample-controller => k8s.io/sample-controller v0.28.8
replace k8s.io/sample-controller => k8s.io/sample-controller v0.28.9

replace k8s.io/dynamic-resource-allocation => k8s.io/dynamic-resource-allocation v0.28.8
replace k8s.io/dynamic-resource-allocation => k8s.io/dynamic-resource-allocation v0.28.9

replace k8s.io/kms => k8s.io/kms v0.28.8
replace k8s.io/kms => k8s.io/kms v0.28.9

replace k8s.io/endpointslice => k8s.io/endpointslice v0.28.8
replace k8s.io/endpointslice => k8s.io/endpointslice v0.28.9
Loading
Loading