Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor fixes to the GNSS ZTD downloader #700

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

jlmaurer
Copy link
Collaborator

Description

  • Graceful failure if no stations in the input file are available from the source repo
  • Handled the case where there are duplicate station names
  • Fixed some path typos and type problems

Motivation and Context

Tried running GNSS downloader on a single example station and was getting failures.

How Has This Been Tested?

  • unit tests pass locally

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement / cleanup (non-breaking change which makes things better)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jlmaurer jlmaurer mentioned this pull request Feb 3, 2025
9 tasks
@jlmaurer jlmaurer merged commit 76cbe58 into dbekaert:dev Feb 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant