Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check containment #685

Merged
merged 13 commits into from
Jan 15, 2025
Merged

Fix check containment #685

merged 13 commits into from
Jan 15, 2025

Conversation

jlmaurer
Copy link
Collaborator

@jlmaurer jlmaurer commented Sep 13, 2024

Description

Attempts to fix #684

Motivation and Context

If the global bounding box is larger than the world box [-90, 90, -180, 180], then the current code gets unhappy (see #684). This checks whether the world box fits inside the requested box and sets the requested box to equal the world.

How Has This Been Tested?

  • added unit tests to check the basic functionality
  • Made a bunch of formatting tweaks to fix ruff issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have added an explanation of what your changes do and why you'd like us to include them.
  • I have written new tests for your core changes, as applicable.
  • I have successfully ran tests with your changes locally.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

.circleci/config.yml Outdated Show resolved Hide resolved
@jlmaurer jlmaurer marked this pull request as ready for review January 13, 2025 20:09
tools/RAiDER/interpolator.py Outdated Show resolved Hide resolved
test/test_intersect.py Outdated Show resolved Hide resolved
@jlmaurer jlmaurer force-pushed the fix_check_containment branch from 7ea7088 to 2e90144 Compare January 15, 2025 01:08
@jlmaurer
Copy link
Collaborator Author

@jhkennedy thank you I think we got it! If you're good to merge we can start rebasing the other PRs

Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I haven't done a highly detailed review, but I don't see anything here that would require it.

@jlmaurer jlmaurer merged commit 6457335 into dbekaert:dev Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] checkContainment fails on global zenith HRES
2 participants