Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling refs/tags/v0.4.7 into dev #631

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Pulling refs/tags/v0.4.7 into dev #631

merged 1 commit into from
Apr 25, 2024

Conversation

dbekaert
Copy link
Owner

Fast-forward of main to dev failed!

@dbekaert dbekaert added the bot label Feb 20, 2024
@dbekaert dbekaert self-assigned this Feb 20, 2024
@jlmaurer
Copy link
Collaborator

@dbekaert do you know if this is still needed?

@jhkennedy
Copy link
Collaborator

@jlmaurer yes -- we want all the tags, which are applied to the main branch, to be direct descendants of the dev branch as well so that the version numbers, which are based on git tags, are picked up correctly.

@jhkennedy
Copy link
Collaborator

@jlmaurer, since this is old, let me make sure the version numbers will be correct once merged. I'll merge it if so.

Copy link
Collaborator

@jhkennedy jhkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so, right now, from the dev branch, if you check the version number you'll get:

>>> python -m setuptools_scm
0.4.7.dev40+g3e04129

which is incorrect since v0.4.7 has already been released. Had the fast-forward merge worked, we would be getting:
0.4.8.dev25+g9c10639

If I merge this PR, then we'll get:
0.4.8.dev30+gb14d1b9

Which accounts for the stuff pushed to dev in between the release and the merge-back attempt.

So, it looks like we're good to merge. :shipit:

@jhkennedy jhkennedy merged commit 9ddc530 into dev Apr 25, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants