Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Use event interfaces #30

Open
daxpedda opened this issue Apr 23, 2021 · 3 comments
Open

Use event interfaces #30

daxpedda opened this issue Apr 23, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@daxpedda
Copy link
Owner

Currently Event::add_exception and Event::add_stacktrace don't follow Sentry's exception interface properly.

With sentry-native 0.4.9 this was fixed.
While updating I noticed to adapt to this change in sentry-contrib-native, I will need to do a rather large refactoring. Considering that the original plan was to integrate this into the Sentry's Rust crate, see getsentry/sentry-rust#299, I would like to leave everything as it is, as integration into Sentry's Rust crate will remove these interfaces entirely.

That said, I'm open to any user-input to tell me otherwise.

@daxpedda daxpedda added the help wanted Extra attention is needed label Apr 23, 2021
@daxpedda
Copy link
Owner Author

@Jake-Shadle I just saw that Embark is using a pure breakpad alternative, do you guys plan to upstream this to sentry-rust?

@Jake-Shadle
Copy link
Contributor

Oops, I somehow missed this notification, sorry for the late response! I don't think we'll be upstreaming the breakpad integration itself into the sentry-rust repo (unless they actually want to maintain it), but rather just have a separate repo with an integration that works with the regular sentry API. Just missing the API pieces right now which is why we had to fork.

@daxpedda
Copy link
Owner Author

There currently is a lot of activity in Sentry moving a lot of Breakpad parts to pure Rust alternatives.
getsentry/symbolic#375
Let's hope my crate will become obsolete 🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants