Move stitching code to prediction module #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MartinSJRogers - Tom and I are keen to move some of the patch stitching to the
pred
module frommodel
since it operates on predictions.Tests are passing but could you take a look a this please? In particular some of the docstrings and the descriptions of
X_t
to advise me of any changes as I'm not sure these make sense.While we're at it, the docstring of
_get_coordinate_extent
I'm not really sure I follow:Could you suggest something more descriptive please?
Finally, should we also consider moving
get_patch_overlap
to the same module? And possibly moving its call insidestitch_clipped_predictions
?