avoid infinite loop in gapfill strategy #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if np.all(target_mask_data == False): | ||
| if i == len(added_mask_dates): | ||
| # if the last date in the list has been reached and no suitable mask is found | ||
| raise ValueError("") |
There was a problem hiding this comment.
Should there be content within the "" here?
There was a problem hiding this comment.
There should indeed, I don't think I understand enough to write an informative error message here, can you suggest one?
| while keep_searching: | ||
| added_mask_date = rng.choice(self.context[context_idx].time) | ||
| # Iterate through a randomly ordered list of dates | ||
| added_mask_dates = rng.choice(self.context[context_idx].time, |
There was a problem hiding this comment.
This seems like a sensible approach to me- happy with this amendment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this should be equivalent behaviour, but with raising an error rather than going into an infinite loop.
I'm finding it quite confusing trying to replicate the previous behaviour.
Basically instead of continuing to sample dates, here I generate a randomly ordered list of the dates and iterate through until a suitable sample is found, raising an error if we don't find one by the end of the list.