feat(project): allow an editors to load other users

feat(editors): allow editors
datatlas-erasme · Jan 29, 2024 · afc76a2 · afc76a2
1 parent 924548b
commit afc76a2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/apps/backend-e2e/src/e2e/user.cy.ts b/apps/backend-e2e/src/e2e/user.cy.ts
@@ -190,13 +190,13 @@ describe('User operations', () => {
       expect(response.body).to.be.an('array');
     });
   });
-  it('Should fail when trying to get all users as an editor.', () => {
+  it('Should succeed when trying to get all users as an editor.', () => {
     cy.login(Cypress.env('editor_credentials'));
     cy.authenticatedRequest({
       method: 'GET',
       url: `/api/users/`,
     }).then((response: Cypress.Response<GetUserDto[]>) => {
-      expect(response.status).to.eq(403);
+      expect(response.status).to.eq(200);
     });
   });
   // UPDATE

diff --git a/apps/backend/src/auth/can-get-users.guard.ts b/apps/backend/src/auth/can-get-users.guard.ts
@@ -21,6 +21,7 @@ export class CanGetUsersGuard extends AuthGuard('local') {
     if (userCredentials === null) {
       return false;
     }
-    return userCredentials.role === Roles.ADMIN;
+
+    return [Roles.ADMIN, Roles.EDITOR].includes(userCredentials.role);
   }
 }