Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1968 - simplify DC by removing dynamic extensions, drivers, spark, scala #1969

Merged
merged 7 commits into from
Nov 16, 2024
Merged

#1968 - simplify DC by removing dynamic extensions, drivers, spark, scala #1969

merged 7 commits into from
Nov 16, 2024

Conversation

kaspersorensen
Copy link
Member

@kaspersorensen kaspersorensen commented Nov 14, 2024 •
edited
Loading

See #1968 for discussion on this approach to renewing DataCleaner.

Upon trying this out, I still see a few subtasks:

  • Bundle as many JDBC drivers in the desktop UI as possible - add MariaDB and SQLite
  • Investigate exceptions in logs during startup
  • See if there is a way to make the native MacOS experience a bit better since we had to drop the Macify library
  • Test on Windows and review release procedure (it has been years)
  • It may be a MacOS thing, and not related to this change, but the UI seems to get sorta "scrambled" once in a while:
image

@kaspersorensen kaspersorensen marked this pull request as ready for review November 14, 2024 20:22
@kaspersorensen kaspersorensen merged commit 58c6e92 into master Nov 16, 2024
1 check passed
@kaspersorensen kaspersorensen deleted the minimal-datacleaner branch November 16, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kaspersorensen