Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to ruby 3.1.4 #39

Merged
merged 1 commit into from
May 7, 2024
Merged

upgrade to ruby 3.1.4 #39

merged 1 commit into from
May 7, 2024

Conversation

wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented May 7, 2024

Purpose

closes: #37

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team May 7, 2024 09:26
@wendelfabianchinsamy wendelfabianchinsamy merged commit ae82d82 into master May 7, 2024
2 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the upgrade-to-ruby-3 branch May 7, 2024 10:37
Copy link

sentry-io bot commented May 8, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: no implicit conversion of Symbol into Integer Re3dataController#index View Issue

Did you find this useful? React with a 👍 or 👎

@wendelfabianchinsamy
Copy link
Contributor Author

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: no implicit conversion of Symbol into Integer Re3dataController#index View Issue

Did you find this useful? React with a 👍 or 👎

I was passing in the page size value incorrectly when testing. The issue has been marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Ruby 3.1.4
2 participants