Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Nokogiri gem #192

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Upgrade the Nokogiri gem #192

merged 3 commits into from
Feb 28, 2024

Conversation

wendelfabianchinsamy
Copy link
Contributor

@wendelfabianchinsamy wendelfabianchinsamy commented Feb 27, 2024

Purpose

closes: #191

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@wendelfabianchinsamy wendelfabianchinsamy self-assigned this Feb 27, 2024
@wendelfabianchinsamy wendelfabianchinsamy requested a review from a team February 27, 2024 17:18
Copy link
Contributor

@svogt0511 svogt0511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor comment, in the gemspec, do we want to update 1 s.required_ruby_version = ['>=2.3']`??

This shows up in rubygems.org

@wendelfabianchinsamy
Copy link
Contributor Author

A minor comment, in the gemspec, do we want to update 1 s.required_ruby_version = ['>=2.3']`??

This shows up in rubygems.org

Great point @svogt0511. I will change this to 3.0.

@wendelfabianchinsamy wendelfabianchinsamy merged commit b3721a2 into master Feb 28, 2024
5 checks passed
@wendelfabianchinsamy wendelfabianchinsamy deleted the upgrade-nokogiri branch February 28, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade nokogiri
4 participants