Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing to Spark Remote for Unit Tests #151

Merged
merged 19 commits into from
Feb 7, 2025

Conversation

sundarshankar89
Copy link
Collaborator

@sundarshankar89 sundarshankar89 commented Feb 5, 2025

Changes

Introduced Managed Spark Remote to run tests effectively. In future, we can also introduce uc dependency to resolve other UC-related integrations if and when required.

Note: This makes the unit test more of an integration test and gets us away from mock sparksession.

Linked issues

Resolves #..

Tests

  • manually tested
  • added unit tests
  • added integration tests

@mwojtyczka mwojtyczka changed the title Introducing to Spark Remote for Tests Introducing to Spark Remote for Unit Tests Feb 5, 2025
Copy link
Contributor

@mwojtyczka mwojtyczka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sundarshankar89 sundarshankar89 marked this pull request as ready for review February 7, 2025 06:04
@sundarshankar89 sundarshankar89 requested a review from a team as a code owner February 7, 2025 06:05
@sundarshankar89 sundarshankar89 requested review from tombonfert and removed request for a team February 7, 2025 06:05
Copy link

github-actions bot commented Feb 7, 2025

✅ 121/121 passed, 1 skipped, 1h2m26s total

Running from acceptance #447

added unit test for applying checks
added apply checks test
Copy link
Contributor

@mwojtyczka mwojtyczka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwojtyczka mwojtyczka merged commit 39042be into main Feb 7, 2025
9 checks passed
@mwojtyczka mwojtyczka deleted the feat/introduce_spark_remote branch February 7, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants