-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow auto liquid clustering #935
Allow auto liquid clustering #935
Conversation
Can you do me one small favor: do you know if Databricks has any documentation that covers this? I'm struggling to find it...I'm fairly confident that if the E2E tests pass, this is valid Databricks SQL, but would be nice to have. |
Part of why I'm interested in the documentation is to see if we are using the most discoverable name for the config. |
Are you set up with hatch in your dev environment? If so, please run |
There are these but nothing in the Databricks official documentation but it is mentioned in this video from last year's summit There was also a PDF provided to us by the PM but not sure if that has changed and probably not a good idea to share it here anyway. Let me know and I can share it if necessary. |
Done ✅ |
No worries, it just means that this will likely be a 'secret' feature of the adapter until the Databricks feature is documented. When you set auto cluster by, do you still need to run optimize manually? Going to pull and push to run the E2E tests. |
Yes - Enabling it for your Databricks workspace is hidden in the account UI under Settings > Feature enablement: |
Do you have an environment where you could write/run an E2E test? Unit test looks good, but would like to see a test similar to https://github.com/databricks/dbt-databricks/blob/main/tests/functional/adapter/liquid_clustering/test_liquid_clustering.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a 'functional' aka E2E test similar to existing liquid clustering tests. Since liquid clustering is an optimization thing, we can't really validate the outcomes, but I just want a regression test to ensure we notice if they change syntax for auto cluster by before final release.
Added that and included auto liquid clustering in the optimize logic since it is still valid to run optimize on liquid clustering with auto selected keys |
Looks good, let me just run tests. If everything is green, I'll merge it in. Thanks! |
Resolves #932
Description
Adds config
auto_liquid_cluster
to allow for tables to beCLUSTER BY AUTO
on creation or update (i.e. incremental run)Checklist
CHANGELOG.md
and added information about my change to the "dbt-databricks next" section.