Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: DX wishlist #21

Closed
4 tasks done
lucascolley opened this issue Nov 18, 2024 · 6 comments
Closed
4 tasks done

DEV: DX wishlist #21

lucascolley opened this issue Nov 18, 2024 · 6 comments
Labels

Comments

@lucascolley
Copy link
Member

lucascolley commented Nov 18, 2024

@asmeurer
Copy link
Member

I wasn't sure about these things (especially allcontributors) because it seemed to require access to the full data-apis organization, and I wasn't clear what that entailed. You should get feedback from @rgommers on this.

@lucascolley
Copy link
Member Author

lucascolley commented Nov 18, 2024

yeah, these are not high priority at all, I just thought it would be useful to keep track of them in an issue somewhere.

I'll try to make it to one of the community meetings, maybe we can discuss then.

@rgommers
Copy link
Member

I already enabled all-contributors when this repo was set up. Pixi sounds great, Codecov sounds fine too (as long as it's the config that doesn't comment but just adds the CI job entry with a link).

Pre-commit: sure, if you like it, go for it - you're doing most of the work here after all. As long as it's not mandatory and not hardcoded into the Pixi config preferably, because that will make it unusable for me. I'm happy for CI to fail and fix it up, or for pre-commit to add an extra auto-fix commit to my PR.

@lucascolley
Copy link
Member Author

Pre-commit: sure, if you like it, go for it - you're doing most of the work here after all. As long as it's not mandatory and not hardcoded into the Pixi config preferably, because that will make it unusable for me.

Okay great, that's the request I was looking for. Currently, pixi run lint installs pre-commit locally, but I understand that that is too workflow-prescriptive (I just punted on fixing it until somebody asked).

@lucascolley
Copy link
Member Author

Codecov sounds fine too (as long as it's the config that doesn't comment but just adds the CI job entry with a link).

Sounds good - please could one of you go to https://app.codecov.io/gh/{your-username}/array-api-extra/new and add the CODECOV_TOKEN secret?

This was referenced Nov 19, 2024
@rgommers
Copy link
Member

Done:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants