fix: add brreg exception handling to coordination and trend alle

data-altinn-no · Nov 21, 2024 · 87b6cb1 · 87b6cb1
1 parent 471dde3
commit 87b6cb1
Showing 1 changed file with 36 additions and 2 deletions.
diff --git a/src/Dan.Plugin.Tilda/Tilda.cs b/src/Dan.Plugin.Tilda/Tilda.cs
@@ -699,7 +699,24 @@ private async Task<List<EvidenceValue>> GetEvidenceValuesTrendAll(EvidenceHarves
                     }
                 }
 
-                await Task.WhenAll(taskList);
+                var taskResult = Task.WhenAll(taskList);
+                try
+                {
+                    await taskResult;
+                }
+                catch (Exception e)
+                {
+                    // Don't want one failed fetch to break the listing of the rest of the orgs
+                    if (taskResult.IsFaulted)
+                    {
+                        var failedTasks = taskList.Where(task => task.IsFaulted).ToList();
+                        foreach (var task in failedTasks)
+                        {
+                            _logger.LogError(task.Exception, task.Exception?.Message);
+                        }
+                        taskList = taskList.Where(task => !task.IsFaulted).ToList();
+                    }
+                }
 
                 foreach (var t in taskList)
                 {
@@ -758,7 +775,24 @@ private async Task<List<EvidenceValue>> GetEvidenceValuesTilsynskoordingeringAll
                     }
                 }
 
-                await Task.WhenAll(taskList);
+                var taskResult = Task.WhenAll(taskList);
+                try
+                {
+                    await taskResult;
+                }
+                catch (Exception e)
+                {
+                    // Don't want one failed fetch to break the listing of the rest of the orgs
+                    if (taskResult.IsFaulted)
+                    {
+                        var failedTasks = taskList.Where(task => task.IsFaulted).ToList();
+                        foreach (var task in failedTasks)
+                        {
+                            _logger.LogError(task.Exception, task.Exception?.Message);
+                        }
+                        taskList = taskList.Where(task => !task.IsFaulted).ToList();
+                    }
+                }
                 taskList = taskList
                     .Where(task => task.Result is not null)
                     .GroupBy(x => x.Result.OrganizationNumber)