Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(platform): npm audit fix #2463

Merged
merged 1 commit into from
Feb 14, 2025
Merged

chore(platform): npm audit fix #2463

merged 1 commit into from
Feb 14, 2025

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Feb 14, 2025

Issue being fixed or feature implemented

NPM audit fails with error, because old lodash.get is being used inside sinon. I will update JS packages later in separate PR

└─ lodash.get
   ├─ ID: lodash.get (deprecation)
   ├─ Issue: This package is deprecated. Use the optional chaining (?.) operator instead.
   ├─ Severity: moderate
   ├─ Vulnerable Versions: 4.4.2
   │ 
   ├─ Tree Versions
   │  └─ 4.4.2
   │ 
   └─ Dependents
      └─ @sinonjs/samsam@npm:8.0.0

What was done?

  • Ignored that audit as a temporary fix

How Has This Been Tested?

Locally

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

Summary by CodeRabbit

  • Chores
    • Refined dependency audit configuration to streamline internal checks and prepare for upcoming library updates.

@pshenmic pshenmic self-assigned this Feb 14, 2025
Copy link
Contributor

coderabbitai bot commented Feb 14, 2025

Walkthrough

A configuration update was made in the .yarnrc.yml file. The change adds a new entry (- lodash.get # TODO: update sinon) to the npmAuditExcludePackages list. This update excludes the mentioned package from npm audit checks without altering the overall structure or any other settings in the file.

Changes

File(s) Change Summary
.yarnrc.yml Added a new entry to npmAuditExcludePackages: - lodash.get # TODO: update sinon

Possibly related PRs

Suggested reviewers

  • QuantumExplorer

Poem

I'm a rabbit with hops so light,
Celebrating changes that shine so bright.
With a tweak in config, audits skip their way,
lodash.get is excluded for a smoother day.
Hoppity cheers from CodeRabbit Inc. to say,
"May your updates make all troubles stray!"


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pshenmic pshenmic changed the base branch from v2.0-dev to master February 14, 2025 08:11
@pshenmic pshenmic changed the title chore(package): npm audit fix chore(platform): npm audit fix Feb 14, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.yarnrc.yml (1)

26-26: LGTM! Consider creating an issue to track the package update.

The addition of lodash.get to npmAuditExcludePackages aligns with the PR's objective to temporarily resolve the npm audit failure. The TODO comment follows the established pattern in the file.

Would you like me to help create an issue to track the update of sinon and removal of the deprecated lodash.get dependency? The issue should include:

  • Current version and vulnerability details
  • Steps to update sinon
  • Testing requirements
  • Acceptance criteria
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ddf4e67 and ea0c138.

📒 Files selected for processing (1)
  • .yarnrc.yml (1 hunks)

Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shumkov shumkov merged commit 1eae781 into master Feb 14, 2025
4 of 6 checks passed
@shumkov shumkov deleted the fix/js-audit branch February 14, 2025 08:29
@thephez thephez added this to the v1.8.x milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants