-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(platform): npm audit fix #2463
Conversation
WalkthroughA configuration update was made in the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.yarnrc.yml (1)
26-26
: LGTM! Consider creating an issue to track the package update.The addition of
lodash.get
tonpmAuditExcludePackages
aligns with the PR's objective to temporarily resolve the npm audit failure. The TODO comment follows the established pattern in the file.Would you like me to help create an issue to track the update of sinon and removal of the deprecated lodash.get dependency? The issue should include:
- Current version and vulnerability details
- Steps to update sinon
- Testing requirements
- Acceptance criteria
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Issue being fixed or feature implemented
NPM audit fails with error, because old lodash.get is being used inside sinon. I will update JS packages later in separate PR
What was done?
How Has This Been Tested?
Locally
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only
Summary by CodeRabbit