Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning about js-sdk security #2106

Closed
wants to merge 3 commits into from

Conversation

thephez
Copy link
Collaborator

@thephez thephez commented Sep 4, 2024

Issue being fixed or feature implemented

Since this SDK doesn't support proofs we need a warning to make sure that is obvious

What was done?

Add warning to top of README

How Has This Been Tested?

N/A

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov
Copy link
Member

shumkov commented Sep 5, 2024

Shall we add a warning to the wallet lib as well to notice that it doesn't verify data (transactions and chain)?

@thephez thephez added the documentation Improvements or additions to documentation label Sep 11, 2024
@shumkov
Copy link
Member

shumkov commented Sep 16, 2024

@thephez it seems CI isn't going to work with your fork. I'll give you write access so you can create branches in this repo

@thephez
Copy link
Collaborator Author

thephez commented Sep 16, 2024

Replaced by #2133

@thephez thephez closed this Sep 16, 2024
@thephez thephez deleted the js-sdk-warning branch September 16, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants