Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand benchmarks to different dep graph shapes. #3841

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

davidmorgan
Copy link
Contributor

Also add: support for setting the benchmark size, support for ignoring failures, and support for the --use-experimental-resolver flag.

The current implementation stack overflows for sizes >500 libraries, because the import walking uses a recursive algorithm; I'll fix that in the next PR. That's what the "ignore failures" flag is for :) as it allows getting output.

> dart run _benchmark --generator=json_serializable --build-repo-path=$PWD/.. benchmark --ignore-failures
json_serializable
shape,libraries,clean/ms,no changes/ms,incremental/ms
loop,1,21831,3934,5459
loop,100,23374,4075,7510
loop,250,29461,4285,13947
loop,500,44638,5220,32247
loop,750,X,X,X
loop,1000,X,X,X
forwards,1,22090,3879,5176
forwards,100,23912,4173,7610
forwards,250,26549,4230,10493
forwards,500,36675,4727,22571
forwards,750,X,X,X
forwards,1000,X,X,X
backwards,1,22396,4115,5306
backwards,100,23500,4204,7321
backwards,250,27423,4164,11095
backwards,500,38999,4895,21654
backwards,750,X,X,X
backwards,1000,X,X,X

Also add: support for setting the benchmark size, support for ignoring failures, and support for the `--use-experimental-resolver` flag.
@davidmorgan davidmorgan requested a review from jensjoha February 10, 2025 14:26
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:build 2.4.2 already published at pub.dev
package:build_config 1.1.2 already published at pub.dev
package:build_daemon 4.0.4 ready to publish build_daemon-v4.0.4
package:build_modules 5.0.11 already published at pub.dev
package:build_resolvers 2.4.4-wip WIP (no publish necessary)
package:build_runner 2.4.15-wip WIP (no publish necessary)
package:build_runner_core 8.0.1-dev ready to publish build_runner_core-v8.0.1-dev
package:build_test 2.2.4-wip WIP (no publish necessary)
package:build_web_compilers 4.1.1 already published at pub.dev
package:scratch_space 1.0.3-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

Copy link

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

@davidmorgan davidmorgan mentioned this pull request Feb 10, 2025
@davidmorgan davidmorgan merged commit 06221ad into dart-lang:master Feb 11, 2025
75 checks passed
@davidmorgan davidmorgan deleted the more-benchmarking branch February 11, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants