Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of Wire library. #12

Closed
Koepel opened this issue Dec 24, 2018 · 5 comments
Closed

Usage of Wire library. #12

Koepel opened this issue Dec 24, 2018 · 5 comments

Comments

@Koepel
Copy link

Koepel commented Dec 24, 2018

By including the "POA/Libraries/Arduino-MS5611" library, you have included wrong use of the Wire library in the file "MS5611.cpp"

See my issue for the MS5611.cpp: jarzebski/Arduino-MS5611#2

The file "MPU6050.cpp" has the same issues: jarzebski/Arduino-MPU6050#4

The file "flyMPU6050.ino" has this issue: VRomanov89/EEEnthusiast#1

@darods
Copy link
Owner

darods commented Dec 26, 2018

wow thanks man, i'll be working on that, thanks for posting the issue.

@darods
Copy link
Owner

darods commented Jan 5, 2019

hey man, i fixed the issue according to your instructions and the info in your profile, thanks again for posting it.

@darods darods closed this as completed Jan 5, 2019
@Koepel
Copy link
Author

Koepel commented Jan 5, 2019

I did a search for "requestFrom" and it is used in six files. I have checked those six files, and I think it is all right.

Did you notice that the fastRegister8 and readRegister8 functions are exactly the same, once the issues has been solved ? There has never been a slow and fast way to do I2C.

Some leftovers are at: "POA/FlightComps(in development)/FlyI2C/flyMS5611/flyMS5611.ino"
Requesting 24 bytes and using only 1, and a while to wait. That is weird.

@darods darods reopened this Jan 8, 2019
@darods
Copy link
Owner

darods commented Jan 9, 2019

Hello man, i fixed the issue, the fastRegister8 only was used once, but readRegister8 is used a lot more, anyway it was fixed, and for the flyMS5611.ino i fixed as well, but it is not working very good, it can only read a registry but in the max value(that is super weird and obviously something is wrong).

thanks again for posting the issue, i will keep the issue open if you find another problem.

@Koepel
Copy link
Author

Koepel commented Jan 9, 2019

The setup function MS5611SetUp() is also called from the loop(). There are a few other MS5611 libraries on Github. I suggest to compare your code with those. You may start with this one: https://github.com/RobTillaart/Arduino/tree/master/libraries/MS5611

@Koepel Koepel closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants