Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into main – Documentation, Enhancements, and Testing Updates #13

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

DarkRockMountain-admin
Copy link
Collaborator

Description

This pull request merges the develop branch into main, introducing key updates that enhance the spacy-ewc library's usability, functionality, and documentation.

  • Related Issue:
  • Type of Change:
    • New feature (non-breaking change that adds functionality)
    • Documentation update (to include expanded content)
    • Bug fix (for minor improvements and test coverage)

Checklist

Please ensure the following guidelines are met:

  • The code follows the style guidelines of this project.
  • A self-review has been performed on the code.
  • The code is well-documented, and comments have been added where necessary.
  • Tests have been added to prove that the fix is effective or that the feature works. All existing tests pass.
  • Commit messages follow the convention type(scope): description.
  • The pull request has no conflicts with the base branch.
  • Any dependent changes have been merged and published in downstream modules.

JRocabruna and others added 3 commits November 15, 2024 16:06
Merge `develop` into `main` – Documentation, Enhancements, and Testing Updates
Defined explicit permissions for contents as read-only in the coverage workflow. This change addresses SSF recommendations by ensuring the GitHub Actions token only has the necessary permissions to perform code coverage analysis. Reduces security exposure by adhering to the principle of least privilege.
ci(workflows): add minimal permissions to coverage workflow
@DarkRockMountain-admin DarkRockMountain-admin added the refactoring Code refactoring to improve structure without changing functionality. label Nov 15, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link
Member

@JRocabruna JRocabruna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments

The merge of the develop branch into main introduces significant enhancements. These changes collectively enhance the usability and functionality of the spacy-ewc library.

Review Checklist

  • Code adheres to the project's coding guidelines.
  • Changes are well-documented.
  • Tests have been added/updated and pass successfully.
  • Commit messages follow the correct format: type(scope): description.
  • No conflicts with the base branch.

Approval

Approved: The changes meet the project's contribution standards and are ready for integration into the main branch.

@JRocabruna JRocabruna merged commit dcd4a8b into develop Nov 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring to improve structure without changing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants